fix: let the provider decide when to reuse an existing subscription ID #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Bertone <[email protected]>
Neurone
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
|
Neurone
changed the title
natanasow
changed the title
victor-yanev
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes #2926 (Websocket subscription creates same subscription ID for new connection from same client) by introducing a new environment variable that allows the JSON-RPC relay provider to choose the desired behavior.
The default value of
WS_SAME_SUB_FOR_SAME_EVENTis set to"true"to match the current default behavior.Related issue(s):
Fixes #2926
Notes for reviewer:
Checklist